Skip to content

fix memory leak in cholmod #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkarrasch merged 2 commits into from
Jul 24, 2026
Merged

fix memory leak in cholmod #733

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
443c147
fix memory leak in cholmod
stevengj Jul 6, 2026
b464359
Merge branch 'main' into patch-4
dkarrasch Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/solvers/cholmod.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1952,22 +1952,22 @@ for TI in IndexTypes
dense_b, dense_b_ptr = wrap_dense_and_ptr(b)

X_Handle = Ptr{cholmod_dense_struct}(dense_x_ptr)
Y_Handle = Ptr{cholmod_dense_struct}(C_NULL)
E_Handle = Ptr{cholmod_dense_struct}(C_NULL)
Y_Handle = Ref(Ptr{cholmod_dense_struct}(C_NULL))
E_Handle = Ref(Ptr{cholmod_dense_struct}(C_NULL))
status = GC.@preserve x dense_x b dense_b begin
$(cholname(:solve2, TI))(
CHOLMOD_A, L,
Ref(dense_b), C_NULL,
Ref(X_Handle), C_NULL,
Ref(Y_Handle),
Ref(E_Handle),
Y_Handle,
E_Handle,
getcommon($TI))
end
if Y_Handle != C_NULL
free!(Y_Handle)
if Y_Handle[] != C_NULL
free!(Y_Handle[])
end
if E_Handle != C_NULL
free!(E_Handle)
if E_Handle[] != C_NULL
free!(E_Handle[])
end
@assert !iszero(status)

Expand Down
Loading