feat: add timeseries to DataType enum#10
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5fbd6ad916
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| Coordinate2 = "coordinate2" | ||
| Connection = "connection" | ||
| Vector = "vector" | ||
| Timeseries = "timeseries" |
There was a problem hiding this comment.
When this enum member is added, tests/test_enums.py::test_datatype_all_matches_backend_serializer still asserts that the complete set of DataType values is the old set without timeseries. The CI workflow runs pytest -q, so this change leaves the test suite failing until the expected set is updated alongside the enum.
Useful? React with 👍 / 👎.
1 participant
adds Timeseries to DataType enum. required for KellisLab/MantisAPI#2089.