fix(row-selection): correct select-all checkbox state for manual pagination#1499
Open
rahulpatwa1303 wants to merge 1 commit intoKevinVandy:v3from
Open
Conversation
|
@rahulpatwa1303 is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel. A member of the Team first needs to authorize it. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes incorrect header checkbox state when using manual pagination.
When only the current page rows are selected, the select-all checkbox
was shown as checked even though only a subset of the total dataset
was selected. The checkbox now correctly reflects global selection
state and shows an indeterminate state.
Reproduction
manualPaginationrowCountExpected
Header checkbox shows indeterminate state.
Actual (before)
Header checkbox appeared checked.
Notes
This change does not affect non-manual pagination behavior.