feat(cloud-agent-next): authenticate git via a credential helper - #5336
Open
kilo-code-bot[bot] wants to merge 2 commits into
Open
feat(cloud-agent-next): authenticate git via a credential helper#5336kilo-code-bot[bot] wants to merge 2 commits into
kilo-code-bot[bot] wants to merge 2 commits into
Conversation
Stop embedding managed GitHub/GitLab/Bitbucket tokens in origin. A get-only helper reads GH_TOKEN / GITLAB_TOKEN / BITBUCKET_TOKEN so setup, submodules, and LFS work, and warm refresh is an env write.
kilo-code-bot
Bot
force-pushed
the
feat/cloud-agent-git-credential-helper
branch
from
August 18, 2026 12:32
edc789c to
7fe8224
Compare
Contributor
Author
Council ReviewAdvisory review — findings reported, no merge decision Specialist votes: 0 block, 4 pass. Advisory mode records these votes but does not aggregate them into a decision.
Findings are counted per specialist; when specialists flag the same line their findings are grouped into one inline comment, so the inline comment count is lower than this total. Code Review SummaryStatus: 4 Issues Found | Recommendation: see the Council Review decision above Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (11 files)
Fix these issues in Kilo Cloud Reviewed by grok-4.6 · Input: 104.7K · Output: 24.3K · Cached: 713.3K Review guidance: REVIEW.md from base branch |
Write GH_TOKEN from leftover PATs when metadata is type:git + platform:github, and only treat that shape as helper-backed when the token is actually present. Cover GitLab port matching and helper no-embed clones that pass a token.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kilo-git-credentialhelper and wire it through reservedGIT_CONFIG_*env so git auth comes fromGH_TOKEN/GITLAB_TOKEN/BITBUCKET_TOKEN.originas a canonical URL. Warm leftovers are stripped so URL-embedded creds cannot shadow the helper.session.execso the helper env is inherited. Generic remotes still embed a token because the helper has no host rule for them./opt/kilo-cloud/kilo-git-credential(DIND-mounted) with a/usr/local/binsymlink. ProfileGIT_CONFIG_*overrides are stripped.Test plan
pnpm exec vitest run src/kilo-git-credential.test.ts src/workspace.test.ts src/session-service.test.ts(192 passed)bun test src/session-bootstrap.test.ts(56 passed)git ls-remote/ submodule / LFS still auth via the helpergit.example.comremote still clones with an embedded token/opt/kilo-cloud/kilo-git-credential