Skip to content

Add tests relationship to Project GraphQL type #3808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
williamjallen wants to merge 1 commit into
base: master
Choose a base branch
from
+200 −0
Open

Add tests relationship to Project GraphQL type #3808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/Models/Project.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\BelongsToMany;
use Illuminate\Database\Eloquent\Relations\HasMany;
use Illuminate\Database\Eloquent\Relations\HasManyThrough;
use Illuminate\Database\Eloquent\Relations\HasOne;
use Illuminate\Support\Carbon;
use Illuminate\Support\Facades\Auth;
Expand Down Expand Up @@ -291,6 +292,14 @@ public function builds(): HasMany
return $this->hasMany(Build::class, 'projectid');
}

/**
* @return HasManyThrough<Test, Build, $this>
*/
public function tests(): HasManyThrough
{
return $this->hasManyThrough(Test::class, Build::class, 'projectid', 'buildid');
}

/**
* @return HasOne<Build, $this>
*/
Expand Down
5 changes: 5 additions & 0 deletions graphql/schema.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,11 @@ type Project {
onlyParents: Boolean = true @scope
): [Build!]! @hasMany(type: CONNECTION)

"A shortcut to all tests for this project for convenience. Not guaranteed to be efficient."
tests(
filters: _ @filter
): [Test!]! @hasManyThrough(type: CONNECTION)

"""
An efficient way to get the number of builds matching a given filter.
"""
Expand Down
186 changes: 186 additions & 0 deletions tests/Feature/GraphQL/ProjectTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Tests\Feature\GraphQL;

use App\Models\Project;
use App\Models\TestOutput;
use App\Models\User;
use Illuminate\Foundation\Testing\DatabaseTransactions;
use Illuminate\Support\Str;
Expand Down Expand Up @@ -1274,4 +1275,189 @@ public function testBuildCountFieldWithFilters(): void
],
]);
}

public function testTestsRelationship(): void
{
$output = TestOutput::create([
'path' => 'a',
'command' => 'b',
'output' => 'c',
]);

// First build with two tests.
$this->projects['public1']->builds()->create([
'name' => 'build1',
'uuid' => Str::uuid(),
])->tests()->createMany([
[
'testname' => 'test1',
'status' => 'passed',
'outputid' => $output->id,
],
[
'testname' => 'test2',
'status' => 'failed',
'outputid' => $output->id,
],
]);

// Second build with a single test.
$this->projects['public1']->builds()->create([
'name' => 'build2',
'uuid' => Str::uuid(),
])->tests()->create([
'testname' => 'test3',
'status' => 'notrun',
'outputid' => $output->id,
]);

// A test belonging to a different project should not be returned.
$this->projects['public2']->builds()->create([
'name' => 'build3',
'uuid' => Str::uuid(),
])->tests()->create([
'testname' => 'test4',
'status' => 'passed',
'outputid' => $output->id,
]);

$this->graphQL('
query($projectId: ID!) {
project(id: $projectId) {
tests {
edges {
node {
name
status
}
}
}
}
}
', [
'projectId' => $this->projects['public1']->id,
])->assertExactJson([
'data' => [
'project' => [
'tests' => [
'edges' => [
[
'node' => [
'name' => 'test1',
'status' => 'PASSED',
],
],
[
'node' => [
'name' => 'test2',
'status' => 'FAILED',
],
],
[
'node' => [
'name' => 'test3',
'status' => 'NOT_RUN',
],
],
],
],
],
],
]);

$output->delete();
}

/**
* Tests that a project with no builds (and therefore no tests) returns an
* empty tests relationship.
*/
public function testTestsRelationshipEmpty(): void
{
$this->graphQL('
query($projectId: ID!) {
project(id: $projectId) {
tests {
edges {
node {
name
}
}
}
}
}
', [
'projectId' => $this->projects['public1']->id,
])->assertExactJson([
'data' => [
'project' => [
'tests' => [
'edges' => [],
],
],
],
]);
}

/**
* Tests that the project's tests relationship can be filtered.
*/
public function testTestsRelationshipWithFilters(): void
{
$output = TestOutput::create([
'path' => 'a',
'command' => 'b',
'output' => 'c',
]);

$this->projects['public1']->builds()->create([
'name' => 'build1',
'uuid' => Str::uuid(),
])->tests()->createMany([
[
'testname' => 'passing_test',
'status' => 'passed',
'outputid' => $output->id,
],
[
'testname' => 'failing_test',
'status' => 'failed',
'outputid' => $output->id,
],
]);

$this->graphQL('
query($projectId: ID!) {
project(id: $projectId) {
tests(filters: { eq: { status: FAILED } }) {
edges {
node {
name
status
}
}
}
}
}
', [
'projectId' => $this->projects['public1']->id,
])->assertExactJson([
'data' => [
'project' => [
'tests' => [
'edges' => [
[
'node' => [
'name' => 'failing_test',
'status' => 'FAILED',
],
],
],
],
],
],
]);

$output->delete();
}
}