Add test output deletion trigger function#3835
Open
williamjallen wants to merge 1 commit into
Open
Conversation
Our current build-focused deletion process is inherently slow for test output deletion because the database cannot efficiently determine the set of tests sharing the same output, but not being part of the builds being deleted. This PR attempts to resolve the issue by creating a delete trigger on the build2test table. When tests are deleted, the trigger deletes related testoutput rows if those rows are not shared with other tests. This approach completely avoids needing to go through the builds relation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our current build-focused deletion process is inherently slow for test output deletion because the database cannot efficiently determine the set of tests sharing the same output, but not being part of the builds being deleted. This PR attempts to resolve the issue by creating a delete trigger on the build2test table. When tests are deleted, the trigger deletes related testoutput rows if those rows are not shared with other tests. This approach completely avoids needing to go through the builds relation.