fix(dashboards): fix padding for golden signals [MA-4653] #2716
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adorack
force-pushed
the
fix/golden-signals-padding
branch
from
8cfe1de to
81f7356
Compare
- When the golden signals renderer had a title, there was a lot of extra whitespace. - Restore padding to previous values (before 7fc13e1).
adorack
force-pushed
the
fix/golden-signals-padding
branch
from
81f7356 to
2a7d2dc
Compare
Chalks
requested changes
Dec 9, 2025
Contributor
Chalks
left a comment
Chalks
left a comment
There was a problem hiding this comment.
this has some edge cases. give me a minute to remember where/what they are.
Chalks
approved these changes
Dec 9, 2025
Contributor
Chalks
left a comment
Chalks
left a comment
There was a problem hiding this comment.
I take it back, I was thinking there were some issues with gateway manager mfe, but this handles that just fine. Thanks for doing this, it's been bothering me (mostly because I think I made it worse recently)
ryanmoore
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
Summary