Skip to content

GitHub Issue 495: Do less capitalization of user-provided names #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-susanh merged 13 commits into from
Dec 31, 2025
Merged

GitHub Issue 495: Do less capitalization of user-provided names #1916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6c28b6c
GitHub Issue #495: Do less capitalization of user-provided names
labkey-susanh Dec 29, 2025
999f4e0
Merge from develop
labkey-susanh Dec 30, 2025
6db3299
Release note
labkey-susanh Dec 30, 2025
a0424c8
Remove capitalization of field in audit details
labkey-susanh Dec 30, 2025
6df8025
release note update
labkey-susanh Dec 30, 2025
27a1a01
Add back change for audit details
labkey-susanh Dec 30, 2025
176ac6c
When generating column label, don't capitalize query name
labkey-susanh Dec 30, 2025
70d4173
release note
labkey-susanh Dec 30, 2025
5d06911
Another re-fixing
labkey-susanh Dec 30, 2025
11ec197
merge from develop
labkey-susanh Dec 31, 2025
c9a61cc
release date and version
labkey-susanh Dec 31, 2025
3b54b37
v7.7.3
labkey-susanh Dec 31, 2025
da00ca9
Fix test expectations
labkey-susanh Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/components/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@labkey/components",
"version": "7.7.2",
"version": "7.7.3",
"description": "Components, models, actions, and utility functions for LabKey applications and pages",
"sideEffects": false,
"files": [
Expand Down
6 changes: 6 additions & 0 deletions packages/components/releaseNotes/components.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
# @labkey/components
Components, models, actions, and utility functions for LabKey applications and pages

### version 7.7.3
*Released*: 31 December 2025
- [GitHub Issue #495](https://github.com/LabKey/internal-issues/issues/495)
- Remove some gratuitous capitalization of field names in audit event details
- When generating a column label for an added parent column in the editable grid, don't capitalize the query name

### version 7.7.2
*Released*: 30 December 2025
- Remove unused `getVolumeMinStep` method
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/internal/components/auditlog/AuditDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export class AuditDetails extends Component<Props> {
<div className="row margin-bottom" key={field}>
<div className="left-padding right-padding">
<span className="audit-detail-row-label right-padding">
{capitalizeFirstChar(field)}
{field}
{!!providedVals.length && (
<LabelHelpTip
iconComponent={<i className="original-value-icon fa fa-info-circle left-padding" />}
Expand Down
6 changes: 3 additions & 3 deletions packages/components/src/internal/components/entities/models.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,19 @@ describe('EntityParentType', () => {
'Display Column',
SCHEMAS.DATA_CLASSES.SCHEMA
);
expect(col.caption).toBe('Dataclass Parents');
expect(col.caption).toBe('dataclass Parents');

col = EntityParentType.create({ schema: SCHEMAS.DATA_CLASSES.SCHEMA, query: 'dataclass' }).generateColumn(
'Display Column',
SCHEMAS.SAMPLE_SETS.SCHEMA
);
expect(col.caption).toBe('Dataclass');
expect(col.caption).toBe('dataclass');

col = EntityParentType.create({ schema: SCHEMAS.SAMPLE_SETS.SCHEMA, query: 'sampletype' }).generateColumn(
'Display Column',
SCHEMAS.SAMPLE_SETS.SCHEMA
);
expect(col.caption).toBe('Sampletype Parents');
expect(col.caption).toBe('sampletype Parents');

col = EntityParentType.create({
schema: SCHEMAS.SAMPLE_SETS.SCHEMA,
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/internal/components/entities/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { ExtendedMap } from '../../../public/ExtendedMap';
import { decodePart, encodePart, SchemaQuery } from '../../../public/SchemaQuery';
import { IEntityDetails } from '../domainproperties/entities/models';
import { SelectInputOption } from '../forms/input/SelectInput';
import { capitalizeFirstChar, caseInsensitive, generateId } from '../../util/utils';
import { caseInsensitive, generateId } from '../../util/utils';
import { QueryColumn, QueryLookup } from '../../../public/QueryColumn';
import { SCHEMAS } from '../../schemas';
import { EntityCreationType } from '../samples/models';
Expand Down Expand Up @@ -107,7 +107,7 @@ export class EntityParentType extends Record({
}

generateColumn(displayColumn: string, targetSchema: string): QueryColumn {
const label_ = this.label ?? capitalizeFirstChar(this.query);
const label_ = this.label ?? this.query;
const parentColName = this.generateFieldKey();

// Issue 40233: SM app allows for two types of parents, sources and samples, and its confusing if both use
Expand Down