Address some miscellaneous warnings #7297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-susanh
approved these changes
Dec 30, 2025
| } | ||
| } | ||
|
|
||
| @Deprecated // Use IntegerUtils.asLong() instead |
Contributor
There was a problem hiding this comment.
Should this method just call IntegerUtils.asLong()?
Contributor
Author
There was a problem hiding this comment.
Probably... I'm double checking with Matt just in case I'm missing something
Contributor
Author
There was a problem hiding this comment.
These methods have been updated to call their IntegerUtils counterparts
| return null==o ? null : o.getClass() == Long.class ? (Long)o : ((Number)o).longValue(); | ||
| } | ||
|
|
||
| @Deprecated // Use IntegerUtils.asLong() instead |
Contributor
There was a problem hiding this comment.
Probably you meant IntegerUtils.asInteger() and same question here as above.
Contributor
Author
There was a problem hiding this comment.
Yes, corrected.
labkey-susanh
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Address some IntelliJ warnings and other miscellaneous nits. No functional changes.