Skip to content

extensions: remove DBConfig from the ABI #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adsharma wants to merge 1 commit into
base: main
Choose a base branch
from
Open

extensions: remove DBConfig from the ABI #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions httpfs/src/http_config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
#include "http_config.h"

#include "common/exception/exception.h"
#include "common/types/value/value.h"
#include "function/cast/functions/cast_from_string_functions.h"
#include "main/db_config.h"

namespace lbug {
namespace httpfs_extension {
Expand All @@ -18,13 +19,13 @@ void HTTPConfigEnvProvider::setOptionValue(main::ClientContext* context) {
if (cacheFileOptionStrVal != "") {
bool enableCacheFile = false;
function::CastString::operation(
string_t{cacheFileOptionStrVal.c_str(), cacheFileOptionStrVal.length()},
common::string_t{cacheFileOptionStrVal.c_str(), cacheFileOptionStrVal.length()},
enableCacheFile);
if (enableCacheFile && context->isInMemory()) {
throw Exception("Cannot enable HTTP file cache when database is in memory");
throw common::Exception("Cannot enable HTTP file cache when database is in memory");
}
context->setExtensionOption(HTTPCacheFileConfig::HTTP_CACHE_FILE_OPTION,
Value::createValue(enableCacheFile));
common::Value::createValue(enableCacheFile));
}
}

Expand Down