fix(file_system): improve lock error message by adding PID and OS error details#450
Merged
adsharma merged 2 commits intoLadybugDB:mainfrom May 4, 2026
Merged
Conversation
ksmeltzer
force-pushed
the
fix/confusing-lock-error
branch
from
e2de2ad to
5af6624
Compare
Contributor
Author
|
All checks have passed! Could a maintainer please take a look when you have a moment? cc @benjaminwinger |
adsharma
requested changes
May 4, 2026
Contributor
adsharma
left a comment
adsharma
left a comment
There was a problem hiding this comment.
LGTM - just one comment.
Contributor
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the lock error message when a process cannot acquire a lock on the database files by adding the blocking process ID (PID) and OS error details to the POSIX lock failure messages using
fcntl(F_GETLK). AddsposixErrMessage()orGetLastError()details directly to the lock failure messages to make debugging easier.This fixes confusing lock errors where users could not identify what process was holding the LadybugDB database lock.
Types of changes
Checklist