Draft
Conversation
added 3 commits
March 16, 2026 11:22
We now use the command override to specify the container role
There was a problem hiding this comment.
Pull request overview
This PR replaces the in-container cron-based job scheduling approach with supercronic, aiming to fix missing/redirected job logs and simplify container roles by using a single shared entrypoint.
Changes:
- Stop installing
cronand switch scheduled job execution tosupercronic. - Remove stdout/stderr redirection from
lb-jobs-cronjob definitions. - Update docker-compose examples to run the cron role via
command: supercronic /config/lb-jobs-cron.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
setup.sh |
Removes cron package installation from the image build. |
lb-jobs-cron |
Removes > /dev/stdout 2>&1 redirections from scheduled jobs. |
bin/cron.sh |
Deletes the dedicated cron entrypoint script. |
Dockerfile |
Adds a Go build stage intended to build/copy supercronic into the final image. |
.examples/docker/docker-compose-public.yml |
Updates job services to use supercronic via command: instead of cron.sh. |
.examples/docker/docker-compose-local.yml |
Updates the cron service to use supercronic via command: instead of cron.sh. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Dockerfile
Outdated
|
|
||
| # Build supercronic | ||
| FROM golang:trixie AS supercronic | ||
| ADD https://github.com/aptible/supercronic.git src |
| restart: always | ||
| user: root | ||
| entrypoint: /usr/local/bin/cron.sh | ||
| command: supercronic /config/lb-jobs-cron |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
lb-jobs-cronClose #183