Fix ImportError: precompute_freqs_cis is now _precompute_freqs_cis on LTXBaseModel#481
Open
Marcel (goodguy1963) wants to merge 1 commit into
Open
Conversation
… LTXBaseModel The standalone function precompute_freqs_cis was refactored to a private method _precompute_freqs_cis on the LTXBaseModel class in the ComfyUI core. Update the import and call site in LTXVModelModified.forward() to use self._precompute_freqs_cis() instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The ComfyUI core recently refactored
precompute_freqs_cisfrom a standalone function incomfy.ldm.lightricks.modelto a private method_precompute_freqs_cison theLTXBaseModelclass.This causes the following error when loading
ComfyUI-LTXVideo:Fix
precompute_freqs_cisfrom the import statement intricks/modules/ltx_model.pyLTXVModelModified.forward()fromprecompute_freqs_cis(...)toself._precompute_freqs_cis(...)Since
LTXVModelModifiedextendsLTXVModel→LTXBaseModel, all required instance attributes (split_positional_embedding,freq_grid_generator) are available viaself.Testing
Verified the module imports successfully in the target ComfyUI environment.