fix(HDB): variable setting broken due to data changes via TP vs TC#7547
Open
hjpalpha wants to merge 3 commits into
Open
fix(HDB): variable setting broken due to data changes via TP vs TC#7547hjpalpha wants to merge 3 commits into
hjpalpha wants to merge 3 commits into
Conversation
hjpalpha
commented
May 23, 2026
| local participantResolved = mw.ext.TeamLiquidIntegration.resolve_redirect(participant) | ||
|
|
||
| local aliases = Array.map(placement.extradata.opponentaliases or {}, TeamTemplate.getPageName) | ||
| aliases = Array.extend(aliases, |
Collaborator
Author
There was a problem hiding this comment.
would we want to set the vars for the teamTemplates too?
if yes them
Suggested change
| aliases = Array.extend(aliases, | |
| aliases = Array.extend(aliases, | |
| placement.extradata.opponentaliases or {}, |
Collaborator
There was a problem hiding this comment.
IMO yes, and eventually migrate retrieval to use templates
(i might be biased given the A/B template issues on AoE :D)
Collaborator
Author
There was a problem hiding this comment.
fwiw i personally prefer doing it via pagenames
if we ever migrate to TT we would need to adjust all consumers
also the TP iirc do not set vars for the tt and only for the pagenames instead
nonetheless feel free to hit the "Commit suggestion"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context: https://discord.com/channels/@me/1506575739535888474/1507815419258339419
Summary
TeamParticipants stores opponent templates into extradata.opponentaliases instead of pagenames (as TC did)
this leads to HDB wiki var setting breaking
as suggested by salt we adjust HDB to work with that instead of adjusting TP as "templates would be preferable"
How did you test this change?
dev