Open
Conversation
This benchmark exhibits non-deterministic performance.
lukego
added a commit
to lukego/LuaJIT-test-cleanup
that referenced
this pull request
Oct 8, 2016
The test harness shuold do this in some suitable way e.g. with values that are reproducible but still contain entropy for the JIT.
Author
|
I pushed an update so that the random seed is not initialized in the benchmark script. This should be done separately by the test harness (if it is able to deal with randomness). For #10 the test harness is running the test N times and using a different but predictable random seed (1..N) each time. On the one hand this means that a full test run should be exposed to entropy, on the other hand it means that each individual test should be readily reproducible e.g. to reproduce the result of run 42 call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This benchmark exhibits non-deterministic performance. See LuaJIT/LuaJIT#218.
I think that it is important to include tests that can demonstrate non-deterministic performance. The challenge I see is to make performance as consistent as possible while including as much entropy as possible on the inputs.
Paraphrasing Dijkstra:
Requires a test harness that can account for variation. More on that to follow...