Skip to content

test(devnet): re-inject --sequence on mismatch in everlight retry loop#124

Merged
mateeullahmalik merged 1 commit intomasterfrom
fix/everlight-sequence-retry
Apr 27, 2026
Merged

test(devnet): re-inject --sequence on mismatch in everlight retry loop#124
mateeullahmalik merged 1 commit intomasterfrom
fix/everlight-sequence-retry

Conversation

@mateeullahmalik
Copy link
Copy Markdown
Contributor

Summary

Fix a real flake in everlight_test.sh exposed on master after PR #123 went green.

RCA

run_tx_with_retry retried 3x with sleep 2 on account sequence mismatch but never reseeded the sequence. lumerad kept reading the stale local sequence cache, so every retry hit the same expected/got delta. Under churn (S2 report retries followed by S3.1 first big tx) this manifested as a hard FAIL of S3.1.

Fix (test-only)

  • Parse expected N from raw_log
  • Strip any prior --sequence flag and re-inject --sequence N on next attempt
  • Bump retries 3 -> 5, sleep 2 -> 3 (still well inside an epoch)

Risks / Rollback

Test-only. No chain, no supernode, no module code touched.

Verification

Master + clean devnet: PASS: 35 FAIL: 0 SKIP: 4 EXIT=0. S3.1 now correctly returns SKIP (legitimate epoch-resource path) instead of failing on a recoverable sequence cache miss.

The everlight test's run_tx_with_retry helper retried up to 3x with sleep 2
on 'account sequence mismatch' but never reseeded the sequence. lumerad
kept reading the stale local sequence cache, so every retry hit the same
expected/got delta. Under load (S2's report churn -> S3.1's first big tx)
this manifested as a hard fail instead of recovering.

Fix:
  - Parse expected sequence from raw_log
  - Strip any prior --sequence flag and re-inject --sequence N
  - Bump retries 3 -> 5, sleep 2 -> 3 (still epoch-safe)

Test-only change. No chain or supernode behavior modified.

Verified locally on master devnet: PASS:35 FAIL:0 SKIP:4 EXIT=0.
@roomote-v0
Copy link
Copy Markdown

roomote-v0 Bot commented Apr 27, 2026

Rooviewer Clock   See task

Reviewed the changes to run_tx_with_retry in everlight_test.sh. The fix correctly addresses the root cause: on sequence mismatch, the expected sequence is now parsed from raw_log and re-injected via --sequence, replacing any stale prior value. The arg-stripping loop handles both --sequence N and --sequence=N forms, edge cases are guarded, and the retry/sleep bump is reasonable. No issues found.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@mateeullahmalik mateeullahmalik merged commit 07e6107 into master Apr 27, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant