Update terminal output and add limiting factor to adaptive output - #1757
Draft
wilfonba wants to merge 5 commits into
Draft
Update terminal output and add limiting factor to adaptive output#1757wilfonba wants to merge 5 commits into
wilfonba wants to merge 5 commits into
Conversation
sbryngelson
reviewed
Aug 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
This PR refines simulation runtime terminal output formatting and adds visibility into which CFL criterion (inviscid/viscous/capillary) is limiting the adaptive time step.
Changes:
- Track per-criterion CFL candidate time steps and select the global limiting criterion.
- Add an MPI helper to allreduce elementwise minima for small real vectors.
- Update printed progress lines to be shorter and (for adaptive CFL) include the limiting criterion tag.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/simulation/m_time_steppers.fpp | Computes per-criterion dt candidates, reduces globally, and records which criterion limits dt. |
| src/simulation/m_start_up.fpp | Updates progress/ETA print formatting and appends limiter tag for adaptive dt runs. |
| src/simulation/m_sim_helpers.fpp | Exposes dt_limiter state and expands CFL helper to return 3 candidate dts. |
| src/common/m_mpi_common.fpp | Adds s_mpi_allreduce_min_vec for elementwise global minima of real vectors. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wilfonba
marked this pull request as draft
August 24, 2026 17:18
Lines of Code
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the runtime terminal output for simulations. The terminal output width is reduced. The following shows a before and after for a constant delta t simulation
The output for a
cfl_const_dtis identical since the delta t is constant. The following shows the before and after for acfl_adap_dtsimulationContribution Policy
We do not accept pull requests generated primarily by AI without genuine understanding or real-world usage context.
All contributions are expected to demonstrate:
If these expectations are not met, we would prefer to implement the changes ourselves rather than spend time reviewing low-effort submissions.
Acknowledgement
PR template credit: junegunn