[pull] master from JuliaLang:master #2014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsize is usually typemax, so need to be careful to not do comparisons after adding to it. Substracting from it should normally be perfectly fine. At worst we should compute a negative amount of space remaining.
Fixes #52100. This avoids doing math on the imaginary component — and instead just asks if their string representation starts with a `-` to determine whether the operator between the components should be `+` or `-`. --------- Co-authored-by: Jameson Nash <[email protected]> Co-authored-by: Dilum Aluthge <[email protected]>
…59670) * The PR for LOADING_CACHE failed to acquire the lock in many places it was newly made mandatory. * The stale_cache_key did not include many relevant parameters. * The `isprecompiled` implementation failed to account for the preferred stdlib logic of loading. * The `isprecompiled` cache failed to account for either newly compiled packages or other changes to the file system. * After parallel precompile noticed a package fails, it would retry with serial precompile, which was very pointless. * Semaphore could be <= 0, leading to deadlock. * After parallel precompile noticed a failure, it would crash, instead of allowing the program to continue on to load the package normally. We had tests for this, but they had gotten removed.
Adapt to major update of JSON.jl: JuliaIO/JSON.jl#374
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )