[pull] master from JuliaLang:master #2140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken in #59961, as `map` deals with trailing singleton axes differently from broadcasting: ```julia julia> map(+, ones(1), ones(1,1)) |> size (1,) julia> broadcast(+, ones(1), ones(1,1)) |> size (1, 1) ``` This PR limits the new method to the case where the ndims match, in which case there are no trailing axes and the two are equivalent. The alternate approach suggested in #59961 (comment) is to reshape the arrays, but this adds overhead that nullifies the performance improvement for small arrays.
We had two sets of constructors: 1) user-facing ones, which mimic `show` (e.g. `MersenneTwister(seed)`, or `MersenneTwister(1, (0, 1002, 0, 1))`), 2) internal ones: - `MersenneTwister(seed, state, vals, ...)` - `MersenneTwister(seed, state)` Internal ones were not practical to use, so they are replaced by a single `_MersenneTwister(undef)` constructor which prepares an uninitialized instance, which can then be initialized by `seed!`, `copy!`, etc. This commit also makes `const` some internal fields, and replaces `Vector` with `Memory` for one of them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )