[pull] master from JuliaLang:master #2153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently use keyword arguments as arbitrary key-value pairs in a
number of places, which I've realized isn't really how they're intended to be
used.
This change fixes this and reduces the JuliaLowering package image size
by about 20% on my machine from `26.910 MiB -> 21.701 MiB`, or when
compiled into sysbase.dylib, `+55MB -> +45MB`. Unfortunately no change to
precompile time as I had hoped, but I figured this is worth doing
anyway.
Lowering performance looks unchanged.
I've just used `Vector{Pair}` or explicit `setattr` calls, but let me
know if there's a better way of doing this.
Also let me know if you have a reason for the difference in size when
compiled into Base---I don't think I'm accidentally producing two copies, but you
never know.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )