Fixed inconsistent stroke width scaling for text in compound objects#4694
Open
vihdutta wants to merge 3 commits intoManimCommunity:mainfrom
Open
Fixed inconsistent stroke width scaling for text in compound objects#4694vihdutta wants to merge 3 commits intoManimCommunity:mainfrom
vihdutta wants to merge 3 commits intoManimCommunity:mainfrom
Conversation
behackl
approved these changes
Apr 15, 2026
Member
behackl
left a comment
There was a problem hiding this comment.
This does look reasonable to me, thanks for catching and fixing this!
Author
|
Looks like everything's great! I'm new to open source so forgive the question, but how do I have this merged with the main branch now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
The current code for scale() in vectorized_mobject.py takes the root mobject's stroke width and sets stroke with family=True as the default. This results in that width being pushed to all descendants including objects with a zero stroke width which should keep their width #4648 . I've modified the code to scale each object's own stroke width which resolves the issue.
Motivation and Explanation: Why and how do your changes improve the library?
Links to added or changed documentation pages
I didn't modify any documentation other than the docstring text for vectorized_mobject.py under VMobject's scale() function for the scale_stroke description.
Further Information and Comments
This is my first time contributing to open source! Let me know if there's other things I had forgotten to consider (comments, documentation wise, etc.)
Reviewer Checklist