MDEV-38499: cmake and compile errors on MacOSX when compiling mariadb from a git tree#4522
Merged
MDEV-38499: cmake and compile errors on MacOSX when compiling mariadb from a git tree#4522
Conversation
vaintroub
requested changes
Jan 9, 2026
21b2b2c to
96b27db
Compare
vaintroub
requested changes
Jan 9, 2026
96b27db to
81f8b6f
Compare
4b02673 to
9ea7208
Compare
Contributor
|
I am sad to see that my experimental change 615340f in #3616 to |
9ea7208 to
0417b45
Compare
vaintroub
requested changes
Jan 13, 2026
Member
vaintroub
left a comment
There was a problem hiding this comment.
Some formatting and comment nitpicks
compiling mariadb from a git tree Fixed sprintf deprecation warnings compiling on MacOSX. Replaced some sprintf calls with equivalent snprintf calls, enough so that "normal" compile on MacOSX (as documented in the docs) completes without warnings.
0417b45 to
46b3089
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the warnings issued by a normal MacOSX compile.
Problems:
On 1: replaced the relevant sprintf with snprintf. On 2: worked around by adding a compiler define with a different name
aliasing the character set variable used with a name that
won't trigger the bison warning
On 3: This is due to the fact that there's a circular dependecy between
mysys and dbug (among others). Turned the warning off by adding a macro
to suppress the duplicate library warning.
Applied the macro to all targets that have a dependency on
the mysys/dbug/strings libraries