Skip to content

<feature>[sdk]: add requestCpu and add errCode#3581

Open
zstack-robot-2 wants to merge 1 commit into5.5.12from
sync/zhong.xian/feat/ZSTAC-80103@@2
Open

<feature>[sdk]: add requestCpu and add errCode#3581
zstack-robot-2 wants to merge 1 commit into5.5.12from
sync/zhong.xian/feat/ZSTAC-80103@@2

Conversation

@zstack-robot-2
Copy link
Copy Markdown
Collaborator

add requestCpuNum and requestMemorySize;
add loudOperationsErrorCode

Resolves: ZSTAC-80103

Change-Id: Ib1c2d3e4f5a6b7c8d9e0f1a2b3c4d5e6f7a8b9c0

sync from gitlab !9440

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml)

Review profile: CHILL

Plan: Pro

Run ID: 70186156-9f96-494c-91a1-a46010e0e4d2

📥 Commits

Reviewing files that changed from the base of the PR and between fe2b5db and 74921d0.

⛔ Files ignored due to path filters (5)
  • sdk/src/main/java/org/zstack/sdk/DeployAppDevelopmentServiceAction.java is excluded by !sdk/**
  • sdk/src/main/java/org/zstack/sdk/DeployModelEvalServiceAction.java is excluded by !sdk/**
  • sdk/src/main/java/org/zstack/sdk/DeployModelServiceAction.java is excluded by !sdk/**
  • sdk/src/main/java/org/zstack/sdk/MatchModelServiceTemplateWithModelAction.java is excluded by !sdk/**
  • sdk/src/main/java/org/zstack/sdk/ModelService.java is excluded by !sdk/**
📒 Files selected for processing (2)
  • testlib/src/main/java/org/zstack/testlib/ApiHelper.groovy
  • utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java
🚧 Files skipped from review as they are similar to previous changes (1)
  • utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java

Walkthrough

将 Groovy 测试库中的三个 bare-metal 辅助方法与它们构造的 SDK Action 类的映射进行了互换/重排;在 CloudOperationsErrorCode 中新增了五个公开的错误代码常量(ORG_ZSTACK_AI_10135ORG_ZSTACK_AI_10139)。

Changes

Cohort / File(s) Summary
ApiHelper 方法映射调整
testlib/src/main/java/org/zstack/testlib/ApiHelper.groovy
交换/重排了三处 DSL 辅助方法与其创建的 org.zstack.sdk.*Action 实例:addBareMetal2Gateway 现在创建 AddBareMetal2DpuChassisActionaddBareMetal2DpuChassis 现在创建 AddBareMetal2GatewayActionaddBareMetal2IpmiChassis 的委托位置随之移动并创建 AddBareMetal2IpmiChassisAction。仅方法内实例化目标发生交换,控制流逻辑无其他改动。
错误代码常量新增
utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java
新增五个公开静态字符串常量:ORG_ZSTACK_AI_10135ORG_ZSTACK_AI_10136ORG_ZSTACK_AI_10137ORG_ZSTACK_AI_10138ORG_ZSTACK_AI_10139(各自初始化为相同的字面值)。

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

彩蛋诗

🐰 我把方法悄悄移,
我把常量悄悄添,
名字配对如搬家,
错误码整齐上阵,
小兔挥爪乐一番。


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive 标题格式正确,遵循 [scope]: 的约定,长度 46 字符,未超过 72 字符限制。 标题描述与实际变更内容不匹配。PR 主要改动是交换了 ApiHelper 中的方法实现和添加错误代码常量,但标题中提及的 'requestCpu' 和 'requestMemorySize' 在实际代码变更中未体现,应更新标题准确反映真实变更。
Description check ❓ Inconclusive 描述中提及添加 requestCpuNum、requestMemorySize 和错误代码,但实际代码变更显示主要是方法实现交换和添加错误常量,内容与实际变更关联性有限。 提供更详细和准确的描述,明确说明 ApiHelper 中方法实现的交换原因,以及新增错误常量的用途,使描述与实际代码变更保持一致。
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/zhong.xian/feat/ZSTAC-80103@@2

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.41.1)
utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java

Comment @coderabbitai help to get the list of available commands and usage tips.

add requestCpuNum and requestMemorySize;
add loudOperationsErrorCode

Resolves: ZSTAC-80103

Change-Id: Ib1c2d3e4f5a6b7c8d9e0f1a2b3c4d5e6f7a8b9c0
@MatheMatrix MatheMatrix force-pushed the sync/zhong.xian/feat/ZSTAC-80103@@2 branch from fe2b5db to 74921d0 Compare March 25, 2026 08:56
@MatheMatrix
Copy link
Copy Markdown
Owner

Comment from ye.zou:

Code Review: ZSTAC-80103 (R2)

进度: 5/11 resolved (45%)
1 critical issue(s) still open

完整 review 见: http://dev.zstack.io:9080/zstackio/zstack/-/merge_requests/9309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants