Improve builtin Lookup#1847
Open
rocky wants to merge 3 commits into
Open
Conversation
Not perfect, but better.
mmatera
reviewed
Jun 28, 2026
| if element.elements[0] == key: | ||
| return element.elements[1] | ||
|
|
||
| # Key not found |
Contributor
There was a problem hiding this comment.
When a key is not in the association, WMA returns Missing[KeyAbsent, <key>]. For instance,
In[1]:= a=Association[{"F":>1,"G":>2}] ;
In[2]:=Lookup[a,"H"]
Out[2]= Missing[KeyAbsent, H]
In[3]:=Lookup[a,{"P","G"}]
Out[3]= {Missing[KeyAbsent, P], 2}
Member
Author
There was a problem hiding this comment.
Thanks for checking and catching. The problem was not in the code, but instead in setting Lookup's attributes.
Add more robustness to test case that assumes an uninitialized variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lookup[]using rules is failing on examples like:This corrects that. It is not perfect: threading over lists of associations and multiple query keys are not supported. But it is better.
The operator form of Lookup is needed to support Paclet install.