fix(graph_dbs): sanitize nested metadata before Neo4j writes#1178
Open
kyan-du wants to merge 1 commit intoMemTensor:mainfrom
Open
fix(graph_dbs): sanitize nested metadata before Neo4j writes#1178kyan-du wants to merge 1 commit intoMemTensor:mainfrom
kyan-du wants to merge 1 commit intoMemTensor:mainfrom
Conversation
Author
|
This PR addresses the root cause described in #1172 and partially in #1122. The existing This PR adds a universal sanitization step that catches all remaining cases. |
2fc7a17 to
d954e4e
Compare
d954e4e to
760a8e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Neo4j node properties only accept primitive values or arrays of primitives. Some MemOS flows (especially SkillMemory and feedback-related flows) can produce nested metadata like:
scripts: dictothers: dictinfoThose values can reach
SET n += $metadataand trigger errors like:Property values can only be of primitive types or arrays thereofCypherTypeError: Map{} encounteredFix
This PR adds a small sanitization layer before Neo4j writes:
This keeps metadata readable while making it safe for Neo4j property storage.
Validation
/product/addflow successfully createdSkillMemorywithout the previous Neo4jMap{}error