Skip to content

fix(graph_dbs): add missing status parameter to Neo4jCommunityGraphDB…#1179

Open
baranchen wants to merge 1 commit intoMemTensor:mainfrom
baranchen:fix/neo4j-community-status-param
Open

fix(graph_dbs): add missing status parameter to Neo4jCommunityGraphDB…#1179
baranchen wants to merge 1 commit intoMemTensor:mainfrom
baranchen:fix/neo4j-community-status-param

Conversation

@baranchen
Copy link

….get_by_metadata

The get_by_metadata method in neo4j_community.py was missing the status parameter that exists in the base class and other implementations (neo4j.py, postgres.py). This caused "unexpected keyword argument 'status'" errors when the search API tried to filter by status.

Changes:

  • Add user_name_flag: bool = True parameter for consistency
  • Add status: str | None = None parameter
  • Add status filter logic in WHERE clause when status is provided
  • Update log messages to include status parameter

Fixes search functionality when using Neo4j Community Edition backend.

Description

Please include a summary of the change, the problem it solves, the implementation approach, and relevant context. List any dependencies required for this change.

Related Issue (Required): Fixes @issue_number

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit Test
  • Test Script Or Test Steps (please provide)
  • Pipeline Automated API Test (please provide)

Checklist

  • I have performed a self-review of my own code | 我已自行检查了自己的代码
  • I have commented my code in hard-to-understand areas | 我已在难以理解的地方对代码进行了注释
  • I have added tests that prove my fix is effective or that my feature works | 我已添加测试以证明我的修复有效或功能正常
  • I have created related documentation issue/PR in MemOS-Docs (if applicable) | 我已在 MemOS-Docs 中创建了相关的文档 issue/PR(如果适用)
  • I have linked the issue to this PR (if applicable) | 我已将 issue 链接到此 PR(如果适用)
  • I have mentioned the person who will review this PR | 我已提及将审查此 PR 的人

Reviewer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed
  • Tests have been provided

….get_by_metadata

The get_by_metadata method in neo4j_community.py was missing the `status`
parameter that exists in the base class and other implementations (neo4j.py,
postgres.py). This caused "unexpected keyword argument 'status'" errors when
the search API tried to filter by status.

Changes:
- Add `user_name_flag: bool = True` parameter for consistency
- Add `status: str | None = None` parameter
- Add status filter logic in WHERE clause when status is provided
- Update log messages to include status parameter

Fixes search functionality when using Neo4j Community Edition backend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant