fix(graph_dbs): add missing status parameter to Neo4jCommunityGraphDB…#1179
Open
baranchen wants to merge 1 commit intoMemTensor:mainfrom
Open
fix(graph_dbs): add missing status parameter to Neo4jCommunityGraphDB…#1179baranchen wants to merge 1 commit intoMemTensor:mainfrom
baranchen wants to merge 1 commit intoMemTensor:mainfrom
Conversation
….get_by_metadata The get_by_metadata method in neo4j_community.py was missing the `status` parameter that exists in the base class and other implementations (neo4j.py, postgres.py). This caused "unexpected keyword argument 'status'" errors when the search API tried to filter by status. Changes: - Add `user_name_flag: bool = True` parameter for consistency - Add `status: str | None = None` parameter - Add status filter logic in WHERE clause when status is provided - Update log messages to include status parameter Fixes search functionality when using Neo4j Community Edition backend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
….get_by_metadata
The get_by_metadata method in neo4j_community.py was missing the
statusparameter that exists in the base class and other implementations (neo4j.py, postgres.py). This caused "unexpected keyword argument 'status'" errors when the search API tried to filter by status.Changes:
user_name_flag: bool = Trueparameter for consistencystatus: str | None = NoneparameterFixes search functionality when using Neo4j Community Edition backend.
Description
Please include a summary of the change, the problem it solves, the implementation approach, and relevant context. List any dependencies required for this change.
Related Issue (Required): Fixes @issue_number
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Reviewer Checklist