Skip to content

Change fetch users logic#609

Merged
MarcelGeo merged 1 commit intodevelopfrom
implement-#3263
Apr 16, 2026
Merged

Change fetch users logic#609
MarcelGeo merged 1 commit intodevelopfrom
implement-#3263

Conversation

@xkello
Copy link
Copy Markdown
Contributor

@xkello xkello commented Apr 11, 2026

Regarding issue: https://github.com/MerginMaps/server-private/issues/3263.

Users were not displayed in search drop-down on removal without refreshing page due to fetching them from a static array. They were fetched at the beginning and never again.

After fix they are fetched from an array which gets refreshed on each addition/removal of an user.

@xkello xkello requested a review from MarcelGeo April 11, 2026 18:53
@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 24289138263

Coverage remained the same at 93.248%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 9805
Covered Lines: 9143
Line Coverage: 93.25%
Coverage Strength: 0.93 hits per line

💛 - Coveralls

await notificationStore.show({
text: `Email was sent to address: ${payload.email}`
})
} catch (err) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix lint

@MarcelGeo MarcelGeo merged commit a0ac896 into develop Apr 16, 2026
4 checks passed
@MarcelGeo MarcelGeo deleted the implement-#3263 branch April 16, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants