feat: migrate snap-simple-keyring#573
Conversation
Feat/remove account
Update to 0 32 0
* 2.0.0 * update changelog * snap: bump manifest to v2.0.0 and update shasum for CI clean tree * chore(changelog): remove Uncategorized sections and format for RC validation * Update packages/site/CHANGELOG.md Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com> * Update packages/site/CHANGELOG.md Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com> * Update packages/snap/CHANGELOG.md Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net> --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: seaona <mariona@gmx.es> Co-authored-by: seaona <54408225+seaona@users.noreply.github.com> Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com> Co-authored-by: Charly Chevalier <charly.chevalier@consensys.net>
* chore: bump accounts dependencies * build: workaround webpack build issue * build: snap.manifest.json * chore: lint * chore: revert snaps-sdk update
* chore: bump snaps SDK * chore: update shasum
* 2.1.0 * fix: fix changelogs * fix: update manifest * fix: remove wrong changelog entry * fix: update snap changelog * fix: formatting * fix: change to patch release * fix: update shasum * fix: package version --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Hassan Malik <hbmalik88@gmail.com>
* feat: update snap with missing methods * chore: update manifest * chore: add changelog entry
* feat: update changelog to prep release * chore: add pr number
|
Caution MetaMask internal reviewing guidelines:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
4b06d54 to
82a05c6
Compare
b05e3b9 to
610b734
Compare
…a39efda54887736241309'
cf57e6b to
0ea97a5
Compare
…packages/snaps/simple-keyring Post-subtree adjustments to fit the accounts monorepo conventions: - Remove .yarnrc.yml (conflicts with accounts root Yarn 4 config) - Remove yarn.lock (Yarn 3 format causes workspace resolution failures) - Remove packageManager fields (accounts root manages Yarn 4) - Remove resolutions block (local patches not present here) - Update homepage/bugs/repository URLs to MetaMask/accounts - Update DAPP_ORIGIN_PRODUCTION to new gh-pages URL - Update build:snaps script in root package.json - Add workspace globs for packages/snaps/* to root package.json - Rewrite wrapper package.json to umbrella shape with installConfig.hoistingLimits - Refresh snap.manifest.json shasum and platformVersion via mm-snap build Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…aths for snap workspace deps - Add build:snaps:deps to root package.json that builds keyring-utils, keyring-api, and keyring-snap-sdk in topological order before the snap - Update build:snaps to call build:snaps:deps first so mm-snap's webpack bundler can resolve workspace packages without a prior full build - Add @metamask/* paths to simple-keyring tsconfig.json so tsc resolves workspace packages to their source (../../*/src) rather than dist/, enabling type-checking on a fresh checkout without building deps first Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Remove icon from gatsby-plugin-manifest to avoid sharp native binary,
which cannot run its install script in the monorepo's isolated
node_modules (lavamoat allow-scripts only scans root node_modules)
- Add raw-loader to site devDependencies; gatsby-plugin-webfonts@2.3.2
uses it via inline loader syntax but does not declare it as a dependency.
Added to .depcheckrc.json ignores because depcheck cannot detect usage
through webpack inline loader syntax (require('raw-loader!...')).
- Add @metamask/keyring-snap-client to build:snaps:deps; the site depends
on it and webpack fails to resolve it if its dist/ doesn't exist
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Snap packages migrated from their standalone repo carry older dep versions and a different package layout. Skip all constraint checks for them via SNAP_PACKAGES and suppress version inconsistency violations via ALLOWED_INCONSISTENT_DEPENDENCIES until a follow-up aligns them with monorepo conventions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Snap packages carry older tooling (ESLint v8, Prettier v2) and different configs that are incompatible with the monorepo's current setup. Exclude packages/snaps/** from ESLint and oxfmt until a follow-up aligns them. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove files that only make sense in the standalone repo context: - .github/ (CI workflows, CODEOWNERS — replaced by accounts repo CI) - .editorconfig, .gitattributes, .nvmrc (standalone dev config) - .yarn/releases, .yarn/plugins (standalone Yarn 3 runtime) .yarn/patches/ is kept — patches are applied per-workspace during yarn install and must be preserved. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The changelog-check script in github-tools iterates workspace patterns in order and returns the first match. With "packages/*" listed first, files under packages/snaps/simple-keyring/ resolve to the phantom "packages/snaps" package (which has no package.json), causing the CI check to fail. Listing more specific patterns first ensures files under packages/snaps/ correctly resolve to their actual package, which is marked private and is therefore skipped by the changelog check. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
0ea97a5 to
c631ed6
Compare
Adding the
snap-simple-keyringrepo withgit subtree(so we keep the commit references and git tags as well).Also adapting the config files to match what we have on this monorepo.
None of the code has changed.