-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: Add eBTC token metadata and logo on Optimism #1781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jtfirek
wants to merge
1
commit into
MetaMask:master
Choose a base branch
from
jtfirek:add-ebtc-optimism
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
29 changes: 29 additions & 0 deletions
29
icons/eip155:10/erc20:0x657e8C867D8B37dCC18fA4Caead9C45EB088C642.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions
7
metadata/eip155:10/erc20:0x657e8C867D8B37dCC18fA4Caead9C45EB088C642.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "name": "ether.fi BTC", | ||
| "symbol": "eBTC", | ||
| "decimals": 8, | ||
| "erc20": true, | ||
| "logo": "./icons/eip155:10/erc20:0x657e8C867D8B37dCC18fA4Caead9C45EB088C642.svg" | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Token name inconsistent with existing mainnet entry
Low Severity
The
namefield is"ether.fi BTC"here, but the same contract address on Ethereum mainnet (eip155:1) is registered as"ether.fi Staked BTC"in this repo's existing metadata and incontract-map.json. CoinMarketCap also lists it as "ether.fi Staked BTC." This discrepancy means the same token will display different names depending on the chain, which could confuse users. Worth verifying the on-chainname()return value and aligning both entries.Reviewed by Cursor Bugbot for commit a1e0002. Configure here.