chore: use single header row for post merge spreadsheet#242
chore: use single header row for post merge spreadsheet#242
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8657b9b3e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| valueInputOption: 'USER_ENTERED', | ||
| requestBody: { values: [[platformLabelFor(platformType)]] }, | ||
| }); |
There was a problem hiding this comment.
In createSheetFromTemplateOrBlank, the fallback path (when no template tab exists) now only writes A1 and skips writing any column headers. This is a regression from the previous behavior, where A2:H2 was populated via headerRowFor(platformType). If template lookup fails (the exact case this branch handles), the generated tab has unlabeled validation columns, which makes the tracker hard to use and can lead to incorrect manual validation updates.
Useful? React with 👍 / 👎.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c8657b9. Configure here.
| range: `${title}!A2:H2`, | ||
| valueInputOption: 'USER_ENTERED', | ||
| requestBody: { values: [headerRowFor(platformType)] }, | ||
| }); |
There was a problem hiding this comment.
Fallback path creates sheets without column headers
Medium Severity
When no template is found, the fallback path in createSheetFromTemplateOrBlank now creates a blank sheet with only the platform label in A1 and no column headers. Previously, headerRowFor(platformType) was called to write headers (like "Pull Request", "Merged Time", "Author", etc.) into row 2. That call was removed as part of this change, but unlike the template-duplication path (where the template itself provides headers), the blank-sheet fallback has no other source for column headers, resulting in a headerless spreadsheet.
Reviewed by Cursor Bugbot for commit c8657b9. Configure here.
| const t = String(type).toLowerCase(); | ||
| if (t === 'mobile') return '📱 Mobile'; | ||
| if (t === 'extension') return '🔌 Extension'; | ||
| if (t === 'mobile') return '📱 Mobile - Pull requests'; |
There was a problem hiding this comment.
headerRowFor function is now dead code
Low Severity
The headerRowFor function is defined but no longer called anywhere — the only two call sites were removed in this change. It likely still needs to be used in the blank-sheet fallback path to write column headers, but if it's truly no longer needed, it can be removed to avoid dead code.
Reviewed by Cursor Bugbot for commit c8657b9. Configure here.
1 participant
The post validation tracker excel template was updated to use a single header row.
Note
Cursor Bugbot is generating a summary for commit c8657b9. Configure here.