Open
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds KeyFactor.created_at serialization and new i18n keys; introduces deterministic sorting and many front-end changes: optimistic voting hooks/panels, PanelContainer/VotePanel/MorePanel, VerticalImpactBar, KeyFactorStrengthItem composition, API-backed optimistic voting flow, prop/type adjustments, and removal of several legacy components. Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant UI as KeyFactor UI
participant Panels as KeyFactorVotePanels
participant Optim as useOptimisticVote
participant API as Backend API
participant Feed as Comments Feed
User->>UI: click vote / open panel
UI->>Panels: open specific panel (impact/downvote/more)
User->>UI: select option & confirm
UI->>Optim: setOptimistic(vote)
Optim-->>UI: update local counts (optimistic)
UI->>API: POST voteKeyFactor
API-->>Feed: persist vote
alt success
Feed->>UI: aggregated update
Optim->>UI: clearOptimistic -> render server counts
else failure
API-->>Optim: error
Optim->>UI: clearOptimistic -> revert UI
end
sequenceDiagram
participant User
participant Anchor as Card Anchor
participant Panel as PanelContainer
participant Parent as Card Parent
User->>Anchor: click ellipsis / vote button
Anchor->>Panel: provide anchorRef for positioning
Panel->>Parent: onVotePanelToggle(true)
Parent->>Parent: ensure exclusivity (close others)
User->>Panel: click outside / close
Panel->>Parent: onVotePanelToggle(false)
Parent->>Panel: closePanel()
Estimated code review effort🎯 4 (Complex) | ⏱️ ~65 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
ncarazon
force-pushed
the
feat/key-factors-new-iteration
branch
from
597275c to
14580b4
Compare
ncarazon
force-pushed
the
feat/key-factors-new-iteration
branch
from
14580b4 to
9858b7a
Compare
ncarazon
force-pushed
the
feat/key-factors-new-iteration
branch
from
d6d2a0c to
629c70a
Compare
ncarazon
force-pushed
the
feat/key-factors-new-iteration
branch
from
629c70a to
4aa477e
Compare
Contributor
|
I think title of linked question shouldn't look like that (one word in every line). Can you please check with design? 
|
cemreinanc
approved these changes
Mar 14, 2026
Contributor
cemreinanc
left a comment
cemreinanc
left a comment
There was a problem hiding this comment.
Left couple of comments. LGTM otherwise.
Contributor
There was a problem hiding this comment.
Why we didn't use a popover component instead of the custom portal/positioning, is it intentional? It would handle SSR, accessibility, click-outside, and positioning out of the box.
Contributor
Author
There was a problem hiding this comment.
Good catch, thanks! I'll try to refactor this, likely in the 2nd iteration PR.
| }, []); | ||
|
|
||
| const toggleOption = useCallback((option: T) => { | ||
| setSelectedOption((prev) => (prev === option ? null : option)); |
Contributor
There was a problem hiding this comment.
these selections looks like they don't have any impect besides ui state. Are we expecting it in upcoming iterations?
Contributor
Author
There was a problem hiding this comment.
Yes, for now it's only handled on the UI side. We’re planning to add backend support for it in upcoming iterations.
ncarazon
force-pushed
the
feat/key-factors-new-iteration
branch
from
890b7c6 to
c20a690
Compare
ncarazon
force-pushed
the
feat/key-factors-new-iteration
branch
from
c20a690 to
b46d152
Compare
ncarazon
force-pushed
the
feat/key-factors-new-iteration
branch
from
b46d152 to
0b0e30b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the 1st iteration of the Key Factors Redesign
Iteration 1: Unified Cards + Voting + Grid Layout
Summary by CodeRabbit
New Features
Internationalization
UI/UX