fix: update CP immediately after predicting#4504
Open
SylvainChevalier wants to merge 1 commit intomainfrom
Open
fix: update CP immediately after predicting#4504SylvainChevalier wants to merge 1 commit intomainfrom
SylvainChevalier wants to merge 1 commit intomainfrom
Conversation
After submitting a prediction, fetch fresh post data (including updated CP) from the API, matching the reaffirm flow pattern. Previously, the predict flow relied solely on revalidatePath which didn't reliably update the client-side CP display. Closes #4437 Co-authored-by: Sylvain <SylvainChevalier@users.noreply.github.com>
SylvainChevalier
temporarily deployed
to
testing_env
GitHub Actions
Inactive
SylvainChevalier
temporarily deployed
to
testing_env
GitHub Actions
Inactive
Contributor
📝 WalkthroughWalkthroughForecastMaker component now maintains a local Changes
Sequence DiagramsequenceDiagram
participant User
participant ForecastMaker
participant ClientPostsApi
participant ChildComponents
User->>ForecastMaker: Click Predict
ForecastMaker->>ForecastMaker: handlePredictionSubmit triggered
ForecastMaker->>ClientPostsApi: getPost(currentPost.id)
activate ClientPostsApi
ClientPostsApi-->>ForecastMaker: Fresh post data
deactivate ClientPostsApi
ForecastMaker->>ForecastMaker: Update currentPost state
ForecastMaker->>ForecastMaker: Call original onPredictionSubmit
ForecastMaker->>ChildComponents: Pass updated post & handlePredictionSubmit
ChildComponents-->>User: Render with updated CP
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SylvainChevalier
temporarily deployed
to
Preview
GitHub Actions
Inactive
Contributor
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
Contributor
Author
|
Seems I can't test this because the preview env doesn't recompute CP at all? |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
front_end/src/components/forecast_maker/index.tsx (1)
35-37: Add minimal error telemetry for CP refresh failures.Line 35-37 silently swallows refresh errors, which makes production debugging hard when CP does not update as expected.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@front_end/src/components/forecast_maker/index.tsx` around lines 35 - 37, The empty catch in the forecast_maker component swallows CP refresh errors; change the anonymous catch to capture the error (catch (err)) and emit minimal telemetry and/or log the error so failures are visible in production (e.g., call your telemetry helper like sendTelemetry or trackError with an event name such as "CPRefreshFailed" and include err.message/stack), then keep the existing comment/behavior if desired; update the catch in front_end/src/components/forecast_maker/index.tsx accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@front_end/src/components/forecast_maker/index.tsx`:
- Around line 31-35: The async fetch in handlePredictionSubmit uses
currentPost.id then unconditionally calls setCurrentPost with the response,
which lets a stale response overwrite newer state; fix by capturing the
request's intended id (e.g., const requestedId = currentPost.id) before awaiting
ClientPostsApi.getPost(requestedId) and, after the await, verify the component
still intends to update that same id (compare requestedId to the latest
currentPost.id or an up-to-date ref) before calling setCurrentPost;
alternatively cancel/ignore responses with an AbortController or mounted flag so
setCurrentPost only runs for the latest in-flight request.
---
Nitpick comments:
In `@front_end/src/components/forecast_maker/index.tsx`:
- Around line 35-37: The empty catch in the forecast_maker component swallows CP
refresh errors; change the anonymous catch to capture the error (catch (err))
and emit minimal telemetry and/or log the error so failures are visible in
production (e.g., call your telemetry helper like sendTelemetry or trackError
with an event name such as "CPRefreshFailed" and include err.message/stack),
then keep the existing comment/behavior if desired; update the catch in
front_end/src/components/forecast_maker/index.tsx accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f489c6e1-eb20-45be-88a3-6528357d669b
📒 Files selected for processing (1)
front_end/src/components/forecast_maker/index.tsx
Comment on lines
+31
to
+35
| const handlePredictionSubmit = useCallback(async () => { | ||
| try { | ||
| const freshPost = await ClientPostsApi.getPost(currentPost.id); | ||
| setCurrentPost(freshPost); | ||
| } catch { |
Contributor
There was a problem hiding this comment.
Protect setCurrentPost from stale async responses.
At Line 34, the fetched result is always applied. If the active post changes while this request is in flight, an older response can overwrite newer state.
Suggested fix
- const handlePredictionSubmit = useCallback(async () => {
+ const handlePredictionSubmit = useCallback(async () => {
+ const submittedPostId = currentPost.id;
try {
- const freshPost = await ClientPostsApi.getPost(currentPost.id);
- setCurrentPost(freshPost);
+ const freshPost = await ClientPostsApi.getPost(submittedPostId);
+ setCurrentPost((prev) =>
+ prev.id === submittedPostId ? freshPost : prev,
+ );
} catch {
// Silently fail - the CP will update on next page load
}
onPredictionSubmit?.();
}, [currentPost.id, onPredictionSubmit]);📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| const handlePredictionSubmit = useCallback(async () => { | |
| try { | |
| const freshPost = await ClientPostsApi.getPost(currentPost.id); | |
| setCurrentPost(freshPost); | |
| } catch { | |
| const handlePredictionSubmit = useCallback(async () => { | |
| const submittedPostId = currentPost.id; | |
| try { | |
| const freshPost = await ClientPostsApi.getPost(submittedPostId); | |
| setCurrentPost((prev) => | |
| prev.id === submittedPostId ? freshPost : prev, | |
| ); | |
| } catch { | |
| // Silently fail - the CP will update on next page load | |
| } | |
| onPredictionSubmit?.(); | |
| }, [currentPost.id, onPredictionSubmit]); |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@front_end/src/components/forecast_maker/index.tsx` around lines 31 - 35, The
async fetch in handlePredictionSubmit uses currentPost.id then unconditionally
calls setCurrentPost with the response, which lets a stale response overwrite
newer state; fix by capturing the request's intended id (e.g., const requestedId
= currentPost.id) before awaiting ClientPostsApi.getPost(requestedId) and, after
the await, verify the component still intends to update that same id (compare
requestedId to the latest currentPost.id or an up-to-date ref) before calling
setCurrentPost; alternatively cancel/ignore responses with an AbortController or
mounted flag so setCurrentPost only runs for the latest in-flight request.
ncarazon
requested changes
Apr 14, 2026
Comment on lines
+41
to
+45
| const { | ||
| group_of_questions: groupOfQuestions, | ||
| conditional, | ||
| question, | ||
| } = currentPost; |
Contributor
There was a problem hiding this comment.
Fresh post only threads into ForecastMaker subtree. Sibling DetailedQuestionCard / DetailedGroupCard in forecaster_question_view still render stale CP from parent postData until revalidatePath lands. If #4437 is about the chart, this won't fix it – lift the refetch to the parent page.
Comment on lines
+32
to
+34
| try { | ||
| const freshPost = await ClientPostsApi.getPost(currentPost.id); | ||
| setCurrentPost(freshPost); |
Contributor
There was a problem hiding this comment.
Double-fetch in prediction flow: prediction_flow_post.tsx:62 already refetches the post in its own onPredictionSubmit. This wrapper now fires a second GET /posts/:id right before it.
Comment on lines
+25
to
+27
| useEffect(() => { | ||
| setCurrentPost(post); | ||
| }, [post]); |
Contributor
There was a problem hiding this comment.
Race: local setCurrentPost(fresh) can be overwritten moments later when the parent re-renders with a staler post prop from revalidatePath, via the useEffect sync. Causes a flash back to stale CP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4437
Summary
Test plan
Generated with Claude Code
Summary by CodeRabbit