rewrite registry/registry list settings#5753
Open
MukjepScarlet wants to merge 20 commits intoMeteorDevelopment:masterfrom
Open
rewrite registry/registry list settings#5753MukjepScarlet wants to merge 20 commits intoMeteorDevelopment:masterfrom
MukjepScarlet wants to merge 20 commits intoMeteorDevelopment:masterfrom
Conversation
Large changes to entity rendering.
Resolved enough issues to be able to load the game again. Entity rendering is still broken but aside from that things seem to mostly work fine.
We need to do a lot of refactoring to deal with the vanilla changes to screens and such. A task for when the new stuff is mapped, maybe.
Regenerated PacketUtils
Just mapping changes
Will not be compatible with 1.21.9 because we had to change some mixin signatures
… for the new input changes
crosby-moe
suggested changes
Oct 7, 2025
Collaborator
crosby-moe
left a comment
crosby-moe
left a comment
There was a problem hiding this comment.
since switching the setting types is a very breaking change, pr should target the mc-update branch rather than master
src/main/java/meteordevelopment/meteorclient/settings/AbstractRegistryItemSetting.java
Outdated
Show resolved
Hide resolved
src/main/java/meteordevelopment/meteorclient/settings/AbstractRegistryListSetting.java
Outdated
Show resolved
Hide resolved
src/main/java/meteordevelopment/meteorclient/settings/BlockListSetting.java
Outdated
Show resolved
Hide resolved
src/main/java/meteordevelopment/meteorclient/settings/EnumSetting.java
Outdated
Show resolved
Hide resolved
MukjepScarlet
force-pushed
the
rewrite-registry-list
branch
2 times, most recently
from
a755af4 to
f9f604b
Compare
Contributor
Author
|
I think I messed up the commit history of this branch... |
Collaborator
|
you tried to merge this into the mc-update branch |
Contributor
Author
|
I'll try to clean it later |
MukjepScarlet
force-pushed
the
rewrite-registry-list
branch
from
f9f604b to
4e7f399
Compare
Contributor
Author
|
Okay now cleaned |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
We have many registry-based values like Block/Item... But now they are of
List. This causes issue if we:.containson them. TypicalList.containsis ofO(n)andSet.containsis ofO(1)~O(log n).ArrayListdoesn't prevent us to do that.This PR is in order to:
How Has This Been Tested?
Videos or screenshots of the changes if applicable.
Checklist: