Skip to content

Changed script install to download-review first#5803

Open
mikefrobbins wants to merge 1 commit intoMicrosoftDocs:mainfrom
mikefrobbins:mr-azcli-553155
Open

Changed script install to download-review first#5803
mikefrobbins wants to merge 1 commit intoMicrosoftDocs:mainfrom
mikefrobbins:mr-azcli-553155

Conversation

@mikefrobbins
Copy link
Collaborator

@mikefrobbins mikefrobbins commented Feb 12, 2026

PR Summary

Fixes AB#553155 - Changed script install to download, review, then install

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.

@learn-build-service-prod
Copy link
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit 57ad854:

💡 Validation status: suggestions

File Status Preview URL Details
docs-ref-conceptual/Latest-version/includes/cli-install-linux-apt.md 💡Suggestion View (azure-cli-latest) Details

docs-ref-conceptual/Latest-version/includes/cli-install-linux-apt.md

  • Line 267, Column 3: [Suggestion: other-site-link-broken - See documentation] Link 'https://manpages.ubuntu.com/manpages/lunar/en/man5/apt.conf.5.html' points to a page that doesn't exist. Check the path or URL and update the link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Azure CLI Linux (apt) install include to discourage piping a remote script directly into an elevated shell by switching to a download → review → run flow.

Changes:

  • Rewords “Option 1” to describe installing via a script (single process) rather than “one command”.
  • Replaces curl ... | sudo bash with steps to download the script, review it locally, and then execute it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

1. Download the script

```bash
curl -fsSL 'https://azurecliprod.blob.core.windows.net/$root/deb_install.sh' -o InstallAzureCLIDeb.sh
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The install script URL was changed from the existing https://aka.ms/InstallAzureCLIDeb alias to a direct blob storage URL. The aka.ms link is already used elsewhere in this repo for the same script (for example, the LTS include), and is less likely to break if the underlying storage path changes. Consider downloading from https://aka.ms/InstallAzureCLIDeb to a file (still allowing review) to keep links consistent and stable.

Suggested change
curl -fsSL 'https://azurecliprod.blob.core.windows.net/$root/deb_install.sh' -o InstallAzureCLIDeb.sh
curl -fsSL 'https://aka.ms/InstallAzureCLIDeb' -o InstallAzureCLIDeb.sh

Copilot uses AI. Check for mistakes.
Comment on lines +46 to +50
After reviewing the contents, make it executable and run it with elevated privileges:

```bash
chmod +x InstallAzureCLIDeb.sh
sudo ./InstallAzureCLIDeb.sh
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running the script via sudo ./InstallAzureCLIDeb.sh can fail on systems where the current filesystem is mounted with noexec, and it also relies on the script having a correct shebang. To make the instructions more robust, consider invoking it explicitly with sudo bash InstallAzureCLIDeb.sh (and you can drop the chmod +x step).

Suggested change
After reviewing the contents, make it executable and run it with elevated privileges:
```bash
chmod +x InstallAzureCLIDeb.sh
sudo ./InstallAzureCLIDeb.sh
After reviewing the contents, run it with elevated privileges using `bash`:
```bash
sudo bash InstallAzureCLIDeb.sh

Copilot uses AI. Check for mistakes.

```bash
chmod +x InstallAzureCLIDeb.sh
sudo ./InstallAzureCLIDeb.sh
Copy link
Contributor

@dcaro dcaro Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is sudo necessary for this script execution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants