Changed script install to download-review first#5803
Changed script install to download-review first#5803mikefrobbins wants to merge 1 commit intoMicrosoftDocs:mainfrom
Conversation
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 57ad854: 💡 Validation status: suggestions
docs-ref-conceptual/Latest-version/includes/cli-install-linux-apt.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
There was a problem hiding this comment.
Pull request overview
Updates the Azure CLI Linux (apt) install include to discourage piping a remote script directly into an elevated shell by switching to a download → review → run flow.
Changes:
- Rewords “Option 1” to describe installing via a script (single process) rather than “one command”.
- Replaces
curl ... | sudo bashwith steps to download the script, review it locally, and then execute it.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 1. Download the script | ||
|
|
||
| ```bash | ||
| curl -fsSL 'https://azurecliprod.blob.core.windows.net/$root/deb_install.sh' -o InstallAzureCLIDeb.sh |
There was a problem hiding this comment.
The install script URL was changed from the existing https://aka.ms/InstallAzureCLIDeb alias to a direct blob storage URL. The aka.ms link is already used elsewhere in this repo for the same script (for example, the LTS include), and is less likely to break if the underlying storage path changes. Consider downloading from https://aka.ms/InstallAzureCLIDeb to a file (still allowing review) to keep links consistent and stable.
| curl -fsSL 'https://azurecliprod.blob.core.windows.net/$root/deb_install.sh' -o InstallAzureCLIDeb.sh | |
| curl -fsSL 'https://aka.ms/InstallAzureCLIDeb' -o InstallAzureCLIDeb.sh |
| After reviewing the contents, make it executable and run it with elevated privileges: | ||
|
|
||
| ```bash | ||
| chmod +x InstallAzureCLIDeb.sh | ||
| sudo ./InstallAzureCLIDeb.sh |
There was a problem hiding this comment.
Running the script via sudo ./InstallAzureCLIDeb.sh can fail on systems where the current filesystem is mounted with noexec, and it also relies on the script having a correct shebang. To make the instructions more robust, consider invoking it explicitly with sudo bash InstallAzureCLIDeb.sh (and you can drop the chmod +x step).
| After reviewing the contents, make it executable and run it with elevated privileges: | |
| ```bash | |
| chmod +x InstallAzureCLIDeb.sh | |
| sudo ./InstallAzureCLIDeb.sh | |
| After reviewing the contents, run it with elevated privileges using `bash`: | |
| ```bash | |
| sudo bash InstallAzureCLIDeb.sh |
|
|
||
| ```bash | ||
| chmod +x InstallAzureCLIDeb.sh | ||
| sudo ./InstallAzureCLIDeb.sh |
There was a problem hiding this comment.
Is sudo necessary for this script execution?
PR Summary
Fixes AB#553155 - Changed script install to download, review, then install
PR Checklist