Use explicit return_all_keys flag; expand tests - #35
Merged
Conversation
MikeGarde
commented
Jul 20, 2026
MikeGarde
commented
Owner
- Change get_value.rs to use the explicit return_all_keys flag to determine if all env keys should be returned, instead of inferring from target_keys being empty.
- In tests/debug.rs, add integration tests to verify dotenv CLI debug output includes keys, file paths, and option assembly; ensure debug surfaces wildcard handling and JSON-defaulting behavior; validate file insights during validation and the exact pre-run command; confirm messages about skipping a variable already set in the environment.
- In tests/wildcard.rs, add a comprehensive wildcard test suite covering prefix, suffix, and middle wildcards with JSON-key outputs; ensure nested variable resolution, empty JSON object when no matches, and that --no-json disables expansion; verify failures for missing literals; deterministic environment via tests/.env.test.
- Change get_value.rs to use the explicit return_all_keys flag to determine if all env keys should be returned, instead of inferring from target_keys being empty. - In tests/debug.rs, add integration tests to verify dotenv CLI debug output includes keys, file paths, and option assembly; ensure debug surfaces wildcard handling and JSON-defaulting behavior; validate file insights during validation and the exact pre-run command; confirm messages about skipping a variable already set in the environment. - In tests/wildcard.rs, add a comprehensive wildcard test suite covering prefix, suffix, and middle wildcards with JSON-key outputs; ensure nested variable resolution, empty JSON object when no matches, and that --no-json disables expansion; verify failures for missing literals; deterministic environment via tests/.env.test.
MikeGarde
force-pushed
the
fix/no-wildcard-match
branch
from
July 20, 2026 02:58
85c6ebb to
da39d30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.