Bug 2491: feat: Update URL extraction to preserve case sensitivity #2550
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug 2491, which stated that the URLs were being converted to lowercase, which potentially caused issues for URLs with uppercase characters.
Contributor
Author
|
Hello guys, I have fixed a bug in the code. It would be great if you could review it. |
ajinabraham
approved these changes
Dec 7, 2025
Member
ajinabraham
left a comment
ajinabraham
left a comment
There was a problem hiding this comment.
Thanks for submitting the PR. Apologies for the wait.
PR looks good. let me test this and merge this soon.
ajinabraham
reviewed
Dec 7, 2025
| checksum, | ||
| urls) | ||
| # Email Etraction Regex | ||
| [u.lower() for u in urls if isinstance(u, str)]) |
Member
There was a problem hiding this comment.
Can this be moved to the scan() function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 2491, which stated that the URLs were being converted to lowercase, which potentially caused issues for URLs with uppercase characters.
Describe the Pull Request
Checklist for PR
tox -e lint,testStaticAnalyzer/tests.py)Additional Comments (if any)