Skip to content

fix(cli/web): allow binding to all addresses if not lan_only#1055

Closed
tpoisonooo wants to merge 1 commit intoMoonshotAI:mainfrom
tpoisonooo:patch-1
Closed

fix(cli/web): allow binding to all addresses if not lan_only#1055
tpoisonooo wants to merge 1 commit intoMoonshotAI:mainfrom
tpoisonooo:patch-1

Conversation

@tpoisonooo
Copy link
Contributor

@tpoisonooo tpoisonooo commented Feb 9, 2026

--public 逻辑有点乱,直接 kimi-web --public 还是 bind local

from kimi-cli:

现在 --public 会正确地将 bind_host 设置为 "0.0.0.0"。

  修改后的逻辑:

  • --host <ip> → 绑定到指定 IP
  • --network → 绑定到 0.0.0.0
  • --public → 绑定到 0.0.0.0(同时 lan_only=False)
  • 默认(无参数)→ 绑定到 127.0.0.1

The logic of --public is a bit confusing, directly kimi-web --public or bind local

from kimi-cli:

--public now correctly sets bind_host to "0.0.0.0".

  Modified logic:

  • --host <ip> → Bind to specified IP
  • --network → bind to 0.0.0.0
  • --public → bind to 0.0.0.0 (with lan_only=False)
  • Default (no parameters) → bind to 127.0.0.1

Signed-off-by: tpoisonooo <khj.application@aliyun.com>
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@tpoisonooo
Copy link
Contributor Author

tpoisonooo commented Feb 9, 2026

现在 PR 不能自己修改 title 么?好像没找到按钮。


Now PR can’t modify the title by itself? Can't seem to find the button.

@tpoisonooo tpoisonooo changed the title improvement(cli/web): allow binding to all addresses if not lan_only fix(cli/web): allow binding to all addresses if not lan_only Feb 10, 2026
@tpoisonooo
Copy link
Contributor Author

现在 PR 不能自己修改 title 么?好像没找到按钮。

Now PR can’t modify the title by itself? Can't seem to find the button.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant