[+] ?

[clansty]

Note

Major config and runtime updates with new features and refactors.

• Config v2.4 migration: registers ConfigMigration_V2_3_V2_4 and sets it as latest; splits GameSystem.KeyMap.DisableIO4 into DisableIO4_1P/DisableIO4_2P/DisableIO4System; renames/moves sections: SkipBoardNoCheck -> OldCabLightBoardSupport, GameSystem.UnstableRate -> Utils.UnstableRate, Fancy.CustomSkinsPlusStatic/Fancy.RsOverride -> Fancy.ResourcesOverride; splits MaimollerIO.P1/P2 into per-player Touch/Button/LED; AdxHidInput.Io4Compact -> DisableButtons.
• New mods: Utils.UnstableRate (center timing indicator); Fancy.ResourcesOverride (static full-scene texture/sprite replacement); GameSystem.OldCabLightBoardSupport (bypass BoardNo/firmware checks and remap billboard LEDs to woofer/roof/center).
• Input refactors: MaimollerIO gains granular per-player enables and guarded LED patches; KeyMap supports per-player/system IO4 disable with targeted Harmony patches; AdxHidInput switches to disableButtons gate.
• UX/tools: DisplayTouchInGame adds combined display modes (4/5), multiple canvas handling, and timer update; configSort.yaml reorganized with new sections; adds checkSort.py to validate YAML vs TOML; updates config banner link; removes .config/dotnet-tools.json.

^{Written by Cursor Bugbot for commit 812097e. This will update automatically on new commits. Configure here.}

[gemini-code-assist]

Summary of Changes

Hello @clansty, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces significant improvements in configuration management, hardware compatibility, and in-game utilities. It includes a new configuration migration, more granular control over IO4 and Maimoller inputs, and support for older cabinet light boards. Additionally, new features such as an unstable rate display and enhanced touch display options are added, alongside a new script to maintain configuration file consistency.

Highlights

• Configuration Migration: A new configuration migration from v2.3 to v2.4 has been introduced, handling several key renames and reorganizations across various game system and fancy settings.
• Granular IO4 Input Control: The IO4 input disabling functionality in KeyMap has been refined, allowing for separate control over 1P, 2P, and system buttons, providing more precise input management.
• Enhanced MaimollerIO Configuration: The MaimollerIO module now offers individual toggles for touch, button, and LED inputs for each player, replacing the previous combined enable/disable flags for P1 and P2.
• Old Cabinet Light Board Support: A new module, OldCabLightBoardSupport, has been added to bypass BoardNo checks and remap billboard LEDs, enabling compatibility with older cabinet light boards.
• Unstable Rate Display: A new utility called UnstableRate has been implemented to provide an in-game visual display of precise timing information for hits during gameplay.
• Improved Touch Display in Game: The DisplayTouchInGame utility has been enhanced to support additional display types, including combined upper and lower frame displays, and now manages multiple game objects for improved flexibility.
• Configuration Consistency Check: A new Python script, checkSort.py, has been added to ensure consistency between the configSort.yaml and AquaMai.zh.toml configuration files.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a significant number of features and refactorings. It adds a configuration migration from v2.3 to v2.4, which involves renaming and restructuring several configuration sections for better granularity, such as splitting Maimoller IO and IO4 disable options. New features include an "Unstable Rate" indicator and support for old cabinet light boards. The touch display debug tool has been refactored for more flexibility. The build script has been improved, and a new script for checking configuration consistency has been added.

Overall, the changes are substantial and well-implemented. I have a few suggestions to improve performance, reduce code duplication, and enhance logging for better maintainability.

[clansty]

你们 AI 能不能说中文

[cursor]

This is the final PR Bugbot will review for you during this billing cycle

Your free Bugbot reviews will reset on January 11

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.