Skip to content

707 Add theming file#711

Open
jaygiang wants to merge 27 commits intomainfrom
707-add-branding
Open

707 Add theming file#711
jaygiang wants to merge 27 commits intomainfrom
707-add-branding

Conversation

@jaygiang
Copy link
Collaborator

No description provided.

@thgaskell
Copy link
Contributor

I think the useRadFishConfig functionality could be pulled into vite-plugin-radfish-theme.js to expose constants directly from Vite.

So inside the template code it could reference values, rather than relying on the config provider:
Example:

<h1>{import.meta.env.RADFISH_APP_NAME}<h1>

Additionally, I think the plugin could also make use of the closeBundle hook to write RADFish theme values directly to the manifest.

@jaygiang jaygiang requested a review from thgaskell February 9, 2026 20:53
@jaygiang jaygiang requested a review from jmtorneros February 9, 2026 21:41
@jaygiang jaygiang requested a review from jmtorneros February 9, 2026 21:41
@theangchen theangchen linked an issue Feb 9, 2026 that may be closed by this pull request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be moved to the packages directory and published to the registry before themes are released.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll work on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add NOAA Branding

2 participants