Update react-radfish to support React 19 #715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update peerDependencies react to ^19.2.1 - Add focus-trap-react dependency required by @trussworks/react-uswds - Add explicit name field to root package.json
Script runs workspace tests, builds packages, then verifies the template works with local file: references. Requires clean git state and discards all changes on exit.
- Update @tanstack/react-table from ^8.16.0 to ^8.21.0 to avoid nested React 18 dependency resolution - Change react peerDependency from "^18.2.0 || ^19.2.1" to "^19.2.1" to prevent duplicate React versions causing runtime errors
Collaborator
|
I'm running into this error on react-javascript after 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
reactpeer dependency to^19.2.1in@nmfs-radfish/react-radfishfocus-trap-react@^10.2.3as direct dependency (required by@trussworks/react-uswds)@trussworks/react-uswdsto^10.2.0verify-build.shscript for local package verificationContext
This PR unblocks future work to resolve ci integrations, which will add test and build steps to the PR workflow. The build step currently fails on
maindue to a missingfocus-trap-reacttransitive dependency from@trussworks/react-uswds.Test plan
npm test --workspaces -- --runpasses (69 tests)npm run build --workspaces --if-presentsucceedsfile:package references (scripts/verify-build.sh)