fix(ci): add test and build steps to PR workflow, allow patch updates#717
Open
fix(ci): add test and build steps to PR workflow, allow patch updates#717
Conversation
- Add `npm test --workspaces -- --run` step to run-tests.yml so tests actually run during PR checks - Add `npm run build --workspaces --if-present` step to verify builds - Fix dependabot.yml to only ignore semver-major updates, allowing patch updates through for security fixes
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm test --workspaces -- --runandnpm run build --workspaces --if-presentsteps to thetestjob inrun-tests.yml— previously the workflow only installed dependencies without actually running tests or buildsdependabot.ymlto only ignoresemver-majorupdates, allowing patch updates through for security fixesTest plan
npm test --workspaces -- --runpasses locally (69 tests)npm run build --workspaces --if-presentsucceeds locally