Conversation
Now the extra providers are loaded from a file path instead of an
import specification making them easier to use for causal tests.
There are a few open questions:
- Whether we want to also have the old functionality of loading
actual modules
- How do the error messages look like when something fails in the
imported provider?
- Do we add a way to specify extra providers (module) in the config
file? These are geared toward supporting something like
`validphys.applgrid` where we do not commit to supporting some
crazy setup by default.
You mean essentially loading everything as "Extra modules"?
Makes sense to me, although I suppose there is an argument that we'd generally want to discourage this sort of option unless it's really necessary. So maybe it shouldn't be too easy! |
|
After reflecting further, I think that if we only allow one way of passing extra scripts, then it should be the old (i.e. current) one, possibly with the UI changed so it is enabled in the config file. I really like to have the invaraint that The other use cases, namely having non standard dependencies certainly are favoured by the package based approach. Regarding having the option in config, it surely allows for arbitrary code execution from reportengine, which may not be all that good for security. |
Now the extra providers are loaded from a file path instead of an
import specification making them easier to use for causal tests.
There are a few open questions:
actual modules
imported provider?
file? These are geared toward supporting something like
validphys.applgridwhere we do not commit to supporting somecrazy setup by default.
cc @nhartland