Skip to content

Conversation

@pablo-garay
Copy link
Contributor

Description

Usage

# Add snippet demonstrating usage

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 20, 2025

Greptile Overview

Greptile Summary

This PR updates the GitHub Actions workflow template version from v0.22.3 to v0.66.0 in the build-test-publish-wheel workflow. The change involves updating a single line that references the external CI template from the NVIDIA-NeMo/FW-CI-templates repository. This is an infrastructure maintenance update that brings the Curator project's CI workflow up to date with the latest template version, likely to access newer features, bug fixes, and security improvements. The workflow parameters (dry-run mode, python package name, Python version 3.10) and secrets configuration remain unchanged, indicating the newer template maintains backward compatibility with the existing workflow configuration.

PR Description Notes:

  • The PR description template is incomplete with placeholder text and empty sections
  • No actual description of the changes or rationale is provided
  • Usage example section contains placeholder code
  • Checklist items are unchecked

Important Files Changed

Filename Score Overview
.github/workflows/build-test-publish-wheel.yml 3/5 Updated GitHub Actions workflow template reference from v0.22.3 to v0.66.0 with a significant version jump

Confidence score: 3/5

  • This PR requires careful review due to the large version jump in CI template dependency that could introduce breaking changes
  • Score reflects the significant 44-version jump in the template reference which warrants thorough testing before merge, though existing parameters suggest backward compatibility
  • Pay close attention to .github/workflows/build-test-publish-wheel.yml and ensure the new template version works correctly with current workflow configuration

Sequence Diagram

sequenceDiagram
    participant Developer
    participant GitHub
    participant "CI Workflow"
    participant "NeMo FW-CI-templates"
    participant TestPyPI
    participant Slack

    Developer->>GitHub: "Push to main/release branch"
    GitHub->>GitHub: "Trigger workflow on push event"
    GitHub->>"CI Workflow": "Start build-test-publish-wheel job"
    "CI Workflow"->>"NeMo FW-CI-templates": "Call [email protected]"
    "NeMo FW-CI-templates"->>"NeMo FW-CI-templates": "Build nemo_curator wheel (Python 3.10)"
    "NeMo FW-CI-templates"->>"NeMo FW-CI-templates": "Run tests on built wheel"
    "NeMo FW-CI-templates"->>TestPyPI: "Publish wheel (dry-run mode)"
    TestPyPI-->>"NeMo FW-CI-templates": "Publish result"
    "NeMo FW-CI-templates"->>Slack: "Send notification to release channel"
    "NeMo FW-CI-templates"->>Slack: "Send notification to admin channel"
    "NeMo FW-CI-templates"-->>"CI Workflow": "Job completion status"
    "CI Workflow"-->>GitHub: "Workflow result"
    GitHub-->>Developer: "Workflow completion notification"
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants