fix: plugins cause circular imports #162
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @nabinchha - plugins that import from
data_designer.engine.column_generators.generators.base(to subclassColumnGenerator) caused circular import errors during plugin discovery.That is because base.py imported
COLUMN_TYPE_EMOJI_MAPfrom column_types.py at module level. Since column_types.py instantiates PluginManager() at import time (which triggers plugin discovery), this created a circular import chain:plugin.module → base.py → column_types.py → PluginManager → plugin.module
The fix was to change the
COLUMN_TYPE_EMOJI_MAPimport in base.py from module-level to a lazy import inside the log_pre_generation() method where it's actually used.Also added a test which fails before this fix, and passes after.