GPTModelProvider Make use_arbitrary_attention_mask configurable #1807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that downstream project can have more control over this. If None, it will be determined by the default behavior (arbitrary only when context_parallel==1). We will need to set to False when using packed/remove-padding (THD) data format. Signed-off-by: Hollow Man <[email protected]>
yaoyu-33
approved these changes
Dec 30, 2025
Contributor
|
/ok to test 839ed99 |
HollowMan6
added a commit
to HollowMan6/Megatron-Bridge
that referenced
this pull request
Jan 4, 2026
…IA-NeMo#1807) Signed-off-by: Hollow Man <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
So that downstream project can have more control over this.
If None, it will be determined by the default behavior (arbitrary only when context_parallel==1). We will need to set to False when using packed/remove-padding (THD) data format.
Changelog
use_arbitrary_attention_maskconfig toGPTModelProvider.GitHub Actions CI
See the CI sectionin the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information