Use semaphore and spinlock in tasking::Scheduler #5973
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
CI MESSAGE: [31490037]: BUILD STARTED |
mzient
changed the title
Collaborator
|
CI MESSAGE: [31490386]: BUILD STARTED |
Collaborator
|
CI MESSAGE: [31490037]: BUILD FAILED |
Collaborator
|
CI MESSAGE: [31495691]: BUILD STARTED |
Signed-off-by: Michał Zientkiewicz <[email protected]>
Signed-off-by: Michał Zientkiewicz <[email protected]>
mzient
force-pushed
the
tasking_semaphore
branch
from
995f760 to
bf8e73b
Compare
Signed-off-by: Michał Zientkiewicz <[email protected]>
Collaborator
|
CI MESSAGE: [31496995]: BUILD STARTED |
Collaborator
|
CI MESSAGE: [31495691]: BUILD FAILED |
Collaborator
|
CI MESSAGE: [31496995]: BUILD FAILED |
Collaborator
|
CI MESSAGE: [31496995]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
Separate queue lock
Previously the scheduler featured just one mutex to guard everything. This PR adds a separate lock for the queue of ready tasks. This reduces contention when popping tasks by worker threads.
Use semaphore for queue state tracking
Prior to this change, a condition variable was used to wake up worker threads when ready tasks became available. This PR uses a semaphore which is raised when a task becomes ready and lowered before one is popped.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
dali/core/exec/tasking_test.ccChecklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A