Skip to content

Conversation

@stiepan
Copy link
Member

@stiepan stiepan commented Dec 18, 2025

Category:

Refactoring (Redesign of existing code that doesn't affect functionality)

Description:

  • Moves inflate from experimental to decoders
  • Adjusts the tests and docs to use the new alias
  • In a small subset of inflate tests, keeps the experimental alias and checks if the proper warning is raised
  • Fixes docs hiding for ndd
  • Bumps the remove-deprecated cut-off for ndd to 2.0 (inclusive).

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Please take a look at the documentation (when it's ready in CI or locally):

  • is the decoders.inflate present in fn and ndd?
  • is it not present in experimental of fn and ndd?
  • I tested locally if adjusted __module__ fix removes page in ndd (it does). In this case, however, the operator is removed from the docs not becuase of docs hiding, but because deprecation cut-off removes it completely from ndd.experimental.
  • isn't there someting else missing from the ndd now that I could have missed?

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-4505

…ias, but hide it from the docs

Signed-off-by: Kamil Tokarski <[email protected]>
…ias and validate deprecation warning

Signed-off-by: Kamil Tokarski <[email protected]>
… from the docs from regular ops and fns

Signed-off-by: Kamil Tokarski <[email protected]>
… decoders.inflate towards experimantal.inflate

Signed-off-by: Kamil Tokarski <[email protected]>
@klecki klecki self-assigned this Dec 18, 2025
@stiepan stiepan changed the title Move inflate from experimental to decoders Move inflate from experimental to decoders, fix doc hiding for ndd, bump deprecation cut-off for ndd to 2.0 Dec 18, 2025
@stiepan
Copy link
Member Author

stiepan commented Dec 18, 2025

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [40451684]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [40451684]: BUILD PASSED

@stiepan
Copy link
Member Author

stiepan commented Dec 19, 2025

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [40505354]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [40505354]: BUILD PASSED

@stiepan stiepan merged commit c2aca49 into NVIDIA:main Dec 19, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants