[Chore]: Update Dflash recipes to use dpace#1775
Conversation
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
Signed-off-by: h-guo18 <67671475+h-guo18@users.noreply.github.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1775 +/- ##
==========================================
- Coverage 76.92% 76.64% -0.29%
==========================================
Files 511 511
Lines 56360 56395 +35
==========================================
- Hits 43356 43225 -131
- Misses 13004 13170 +166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
What does this PR do?
Type of change: Chore (recipe update)
Makes D-PACE the position-loss weighting for all DFlash recipes, following #1724 (which set
dflash_loss_objective=dpaceas the config default). The recipes still carrieddflash_loss_decay_factor, which is ignored once the objective defaults todpace(and emits a runtime warning). This PR removes those now-dead overrides so the recipes inherit the dpace default, and documents how to opt back into static decay.modelopt_recipes/general/speculative_decoding/dflash.yaml: dropdflash_loss_decay_factor: 4.0, surfacedflash_dpace_alpha: 0.5, and comment how to switch back to decay.tools/launcher/examples/**DFlash recipes (Qwen3-8B / Qwen3-30B-A3B / Qwen3.5-4B / MiniMax-M2.7 / gpt-oss-20b): remove the deaddflash.dflash_loss_decay_factor=Noverride.Domino recipes are intentionally left unchanged — Domino uses its own base/final dual loss and does not implement the dpace objective.
Usage
Testing
Recipe/config-only change; no code logic. The dpace default and config validation are covered by the unit tests in #1724 (
tests/unit/torch/speculative/plugins/test_hf_dflash.py).Before your PR is "Ready for review"
dflash_loss_objective: decay.CONTRIBUTING.md: N/AAdditional Information
Stacked on #1724 — set the PR base to
haoguo/dpaceso the diff shows only the recipe changes, and merge after #1724 (depends on itsdflash_dpace_alphaconfig field).