Fix space issue with ZH ITN #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anand Joseph <[email protected]>
Update FST paths Signed-off-by: anand-nv <[email protected]>
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
tbartley94
previously approved these changes
Dec 5, 2024
Member
tbartley94
left a comment
tbartley94
left a comment
There was a problem hiding this comment.
Clarifying questions, but LGTM as long as tests pass
| GraphFst, | ||
| delete_extra_space, | ||
| delete_space, | ||
| delete_zero_or_one_space, |
Member
There was a problem hiding this comment.
Do we have a singular delete space that we can just use a kleene question with?
|
|
||
| def __init__(self): | ||
| super().__init__(name="word", kind="classify") | ||
| word = pynutil.insert('name: "') + pynini.closure(NEMO_NOT_SPACE, 1) + pynutil.insert('"') |
Member
There was a problem hiding this comment.
remind me on this syntax, is the closure(...,1) equivalent to 0 or 1 or match exactly one?
Signed-off-by: Simon Zuberek <[email protected]>
ngachchi
pushed a commit
to ngachchi/NeMo-text-processing
that referenced
this pull request
Jun 23, 2025
* Fix space issue with ZH ITN Signed-off-by: Anand Joseph <[email protected]> * Update Jenkinsfile Update FST paths Signed-off-by: anand-nv <[email protected]> --------- Signed-off-by: Anand Joseph <[email protected]> Signed-off-by: anand-nv <[email protected]> Signed-off-by: Simon Zuberek <[email protected]> Co-authored-by: Anand Joseph <[email protected]> Co-authored-by: anand-nv <[email protected]> Signed-off-by: Namrata Gachchi <[email protected]>
FredHaa
pushed a commit
to FredHaa/NeMo-text-processing
that referenced
this pull request
Aug 15, 2025
* Fix space issue with ZH ITN Signed-off-by: Anand Joseph <[email protected]> * Update Jenkinsfile Update FST paths Signed-off-by: anand-nv <[email protected]> --------- Signed-off-by: Anand Joseph <[email protected]> Signed-off-by: anand-nv <[email protected]> Signed-off-by: Simon Zuberek <[email protected]> Co-authored-by: Anand Joseph <[email protected]> Co-authored-by: anand-nv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
The fix addresses an incorrectly applied closure over a single character token in the
WORDgrammar, resulting in all strings being classified asWORDSand subsequently skipped for denormalization.Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.