feat: add gpu container support to microvm driver#1143
Open
Conversation
drew
force-pushed
the
dn/vcaux-brisebo/vm-container-support
branch
from
ea7a545 to
5943739
Compare
elezar
reviewed
May 4, 2026
| # TODO(gpu): Pin SHA-256 checksum for reproducible builds. Compute with: | ||
| # curl -fsSL <url> | sha256sum | ||
| RUN curl -fsSL \ | ||
| "https://us.download.nvidia.com/XFree86/Linux-x86_64/${NVIDIA_DRIVER_VERSION}/NVIDIA-Linux-x86_64-${NVIDIA_DRIVER_VERSION}.run" \ |
Member
There was a problem hiding this comment.
This seems brittle since the user mode driver version needs to match the kernel mode driver (in the VM) exactly. Why is the user mode driver not installed in the VM itself?
elezar
reviewed
May 4, 2026
| /// image like `ubuntu:latest` instead of the GPU sandbox Dockerfile. | ||
| fn warn_missing_gpu_userspace(rootfs: &Path) { | ||
| let nvidia_smi_candidates = [ | ||
| "usr/bin/nvidia-smi", |
Member
There was a problem hiding this comment.
On some systems nvidia-smi is installed at /usr/sbin/nvidia-smi.
elezar
reviewed
May 4, 2026
Comment on lines
+63
to
+65
| # Must match NVIDIA_DRIVER_VERSION in sandboxes/nvidia-gpu/versions.env | ||
| # and sandboxes/nvidia-gpu/Dockerfile ARG NVIDIA_DRIVER_VERSION | ||
| NVIDIA_OPEN_VERSION="${NVIDIA_OPEN_VERSION:-580.159.03}" |
Member
There was a problem hiding this comment.
If it must match this version, why not just source the env file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Changes
Testing
mise run pre-commitpassesChecklist